Skip to content

Commit 5878cb1

Browse files
committed
.github: use docker build in release workflow
The release workflow previously called 'make release' to produce the release artifacts. This commit changes the workflow to first build our helper Docker image and then use it to produce the release artifacts, ensuring they're constructed in a consistent environment that can be easily reproduced outside of CI. Building the Docker image here adds on perhaps 2-3 minutes to the workflow, but release workflows are performed very infrequently (only on a v* tag push) . Note also that this eliminates a location where Go toolchain version state needs to be tracked.
1 parent a3b052f commit 5878cb1

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/release.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ jobs:
3737
exit 1
3838
fi
3939
40-
- name: setup go ${{ env.GO_VERSION }}
41-
uses: actions/setup-go@v5
42-
with:
43-
go-version: '${{ env.GO_VERSION }}'
44-
4540
- name: checkout release tag
4641
run: git checkout ${{ env.RELEASE_VERSION }}
4742

43+
- name: build release helper docker image
44+
run: |
45+
docker build -t taproot-assets-release-helper \
46+
-f make/builder.Dockerfile make/
47+
4848
- name: build release for all architectures
49-
run: make release tag=${{ env.RELEASE_VERSION }}
49+
run: make docker-release tag=${{ env.RELEASE_VERSION }}
5050

5151
- name: Create Release
5252
uses: lightninglabs/gh-actions/action-gh-release@2024.07.24.00

0 commit comments

Comments
 (0)