[WIP] Funding detect double spends #1755
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
funding-detect-double-spends
branch
from
827818b to
9c43df4
Compare
Roasbeef
added
funding
|
Not ready for review. |
halseth
added
the
incomplete
This was referenced Nov 5, 2019
Closed
| // the remaining part of the opening process, we must wait for | ||
| // this process to finish (either successfully or with some | ||
| // error), before the fundingManager can be shut down. | ||
| // We now launch a goroutine that will wiat for the funding |
There was a problem hiding this comment.
Suggested change
| // We now launch a goroutine that will wiat for the funding | |
| // We now launch a goroutine that will wait for the funding |
| ).(*lnwire.AcceptChannel) | ||
| } | ||
|
|
||
| // TestFundingManagerFundingDoubleSpend tests that we correctly handles the |
There was a problem hiding this comment.
Suggested change
| // TestFundingManagerFundingDoubleSpend tests that we correctly handles the | |
| // TestFundingManagerFundingDoubleSpend tests that we correctly handle the |
|
Gonna close this as it is outdated and unfinished. I still think this is the way to go to solve #386 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
fundingmanageraware of transaction spending inputs to the funding transaction, invalidating the funding tx. In this case we will cancel the funding flow.TODO:
pkScriptfor funding tx inputsFixes #1494
Fixes #1623
Blocked by #1910