GitHub: increase itest parallelization to more tranches

[guggero]

With the integration tests being way more stable now (and just failing on certain platforms), we might be able to save a lot of run time by increasing the parallelization.

This is the current baseline to beat (v0.18.0-beta.rc4):

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[guggero]

Not bad for 12 tranches:

Trying with 24 now, just to see if things stay more or less stable.

[yyforyongyu]

Have a few ideas about the failed tests, will push commits to this PR!

[guggero]

Settled on 8-fold parallelity for now, which still gives a nice boost:

This in total saves around 4 hours of run time per CI run.

Sounds like the two tests that became less stable were the Postgres ones. I assume you meant those tests with your comment above, @yyforyongyu?

[yyforyongyu]

@guggero yep - think I found the issue - for postgres backend it looks like the mempool wasn't updated quickly, causing a mined tx lingering there. Detailed in #8809, in short, postgres dbbackend is slow, I increased the timeout value instead, also added some trace logs to help with the debugging and, kept the mempool assertion on checking the non-existence of txns to keep it clean.

[guggero]

Thanks a lot for the fixes, @yyforyongyu! Looks like we got the tests to pass 🎉
Just to see how far we can go, I increased the number of tranches to 16. If that's stable, great. If not, we go back to 8.

[yyforyongyu]

Veery nice gain🎉🎉🎉

[guggero]

Final stats:

Looks like we're almost cutting most times in half, taking many hours off of each CI run.
Thanks a lot for the assist, @yyforyongyu!

[bhandras]

🚀