Implement History WebAPI.
#1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Sep 24, 2025
| } | ||
|
|
||
| pub fn _replaceState(self: *History, state: Env.JsObject, _: ?[]const u8, _url: ?[]const u8, page: *Page) !void { | ||
| const arena = page.session.arena; |
Collaborator
There was a problem hiding this comment.
Thoughts on just storing the session arena in a field?
Contributor
Author
There was a problem hiding this comment.
Not opposed to it but we already take page: *Page in a few places because we need to access things like the page.url so it feels like duplication.
karlseguin
approved these changes
Sep 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the entire
HistoryWebAPI.There are also some modifications to our testing runner because History navigates the page and needs a second
page.wait()to rerun and validate that the state persisted.