Skip to content

Fix a potential segfault on log message for failing to load module #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2025
Merged

Fix a potential segfault on log message for failing to load module #1153

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
521c0f8
Fix a potential segfault on log message for failing to load module
karlseguin Oct 16, 2025
7bb8581
Fix referrer in log (was printing using the src instead :/)
karlseguin Oct 16, 2025
55746f1
log the normalized specifier now that we've extended its lifetime to …
karlseguin Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/browser/js/Context.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ pub fn module(self: *Context, comptime want_result: bool, src: []const u8, url:
const owned_specifier = try self.arena.dupeZ(u8, normalized_specifier);
gop.key_ptr.* = owned_specifier;
gop.value_ptr.* = .{};
try self.script_manager.?.getModule(owned_specifier, src);
try self.script_manager.?.getModule(owned_specifier, url);
}
}
}
Expand Down Expand Up @@ -1171,7 +1171,7 @@ fn _resolveModuleCallback(self: *Context, referrer: v8.Module, specifier: []cons
};

const normalized_specifier = try self.script_manager.?.resolveSpecifier(
self.call_arena,
self.arena, // might need to survive until the module is loaded
specifier,
referrer_path,
);
Expand Down Expand Up @@ -1207,7 +1207,7 @@ fn _resolveModuleCallback(self: *Context, referrer: v8.Module, specifier: []cons

const entry = self.module(true, fetch_result.src(), normalized_specifier, true) catch |err| {
log.warn(.js, "compile resolved module", .{
.specifier = specifier,
.specifier = normalized_specifier,
.stack = try_catch.stack(self.call_arena) catch null,
.src = try_catch.sourceLine(self.call_arena) catch "err",
.line = try_catch.sourceLineNumber() orelse 0,
Expand Down