-
Notifications
You must be signed in to change notification settings - Fork 286
Port Blob to zigdom
#1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Blob to zigdom
#1229
Conversation
karlseguin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't understand why File.zig in in the root of webapi, but Blob.zig is under the file folder?
I was unsure about the folder structure, should everything related to File API go under directory |
There's no hard rule, but since Blob is the parent of File, I was surprised to see But if you think there's more, like ReadableStream and WriteableStream and ?? Then, we can have a file/ folder or whatever else you think is best. I'd probably stick them all in there though....having the child (File.zig) be UP a directory than it's parent (Blob.zig) is weird to me. |
c0433af to
5c9ff9d
Compare
No idea how I removed this single line while rebasing...
No description provided.