Skip to content

Conversation

@nikneym
Copy link
Contributor

@nikneym nikneym commented Nov 21, 2025

No description provided.

@nikneym nikneym requested a review from karlseguin November 21, 2025 08:41
Copy link
Collaborator

@karlseguin karlseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand why File.zig in in the root of webapi, but Blob.zig is under the file folder?

@nikneym
Copy link
Contributor Author

nikneym commented Nov 21, 2025

Don't understand why File.zig in in the root of webapi, but Blob.zig is under the file folder?

I was unsure about the folder structure, should everything related to File API go under directory file? If, for example, File.zig is entrypoint to the API, should it be at the top-level or under the respective folder?

@karlseguin
Copy link
Collaborator

I was unsure about the folder structure, should everything related to File API go under directory file? If, for example, File.zig is entrypoint to the API, should it be at the top-level or under the respective folder?

There's no hard rule, but since Blob is the parent of File, I was surprised to see File.zig in the root, and file/Blob.zig. If anything, I would have expected the opposite, Blob.zig and blob/File.zig If it's just those two, I'd be tempted to stick them both in webapi/.

But if you think there's more, like ReadableStream and WriteableStream and ?? Then, we can have a file/ folder or whatever else you think is best. I'd probably stick them all in there though....having the child (File.zig) be UP a directory than it's parent (Blob.zig) is weird to me.

@nikneym nikneym force-pushed the nikneym/blob-zigdom branch from c0433af to 5c9ff9d Compare November 21, 2025 11:56
No idea how I removed this single line while rebasing...
@karlseguin karlseguin merged commit 1193423 into zigdom Nov 21, 2025
7 of 10 checks passed
@karlseguin karlseguin deleted the nikneym/blob-zigdom branch November 21, 2025 12:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants