add insertAdjacentHTML and other variants
#1242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
approved these changes
Dec 3, 2025
|
|
||
| var iter = body.childrenIterator(); | ||
| while (iter.next()) |child_node| { | ||
| _ = try target_node.insertBefore(child_node, prev_node, page); |
Collaborator
There was a problem hiding this comment.
There's probably some optimization opportunity by using page.insertNodeRelative directly. You'd be able to call page.domChanged(); just once (before the loop), and you could skip the call to page.removeNode (which checks mutationobservers), since you know the children are all newly created (would need to manually set their _parent = null before calling). There might be other small tweaks. Not sure if this API is called enough to warrant it though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports
insertAdjacentHTMLand addsinsertAdjacentTextandinsertAdjacentElementAPIs to zigdom.