Skip to content

browser: fix global object window #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

browser: fix global object window #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/browser/browser.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ pub const Page = struct {

// add global objects
log.debug("setup global env", .{});
try self.session.env.bindGlobal(self.session.window);
try self.session.env.bindGlobal(&self.session.window);

// browse the DOM tree to retrieve scripts
// TODO execute the synchronous scripts during the HTL parsing.
Expand Down Expand Up @@ -359,6 +359,8 @@ pub const Page = struct {
// have loaded.
// https://html.spec.whatwg.org/#reporting-document-loading-status
const evt = try parser.eventCreate();
defer parser.eventDestroy(evt);

try parser.eventInit(evt, "DOMContentLoaded", .{ .bubbles = true, .cancelable = true });
_ = try parser.eventTargetDispatchEvent(parser.toEventTarget(parser.DocumentHTML, html_doc), evt);

Expand All @@ -373,8 +375,13 @@ pub const Page = struct {

// dispatch window.load event
const loadevt = try parser.eventCreate();
defer parser.eventDestroy(loadevt);

try parser.eventInit(loadevt, "load", .{});
_ = try parser.eventTargetDispatchEvent(parser.toEventTarget(Window, &self.session.window), loadevt);
_ = try parser.eventTargetDispatchEvent(
parser.toEventTarget(Window, &self.session.window),
loadevt,
);
}

// evalScript evaluates the src in priority.
Expand Down