Skip to content

Conversation

@francisbouvier
Copy link
Member

No description provided.

@francisbouvier francisbouvier force-pushed the refacto_exec branch 2 times, most recently from 798c42e to 76b5c9e Compare July 8, 2024 16:04
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
@krichprollsch
Copy link
Member

krichprollsch commented Jul 18, 2024

the wpt tests are failing b/c there is a JS error displayed on stderr that wasn't here before.

In this PR:

$ zig build wpt -- --json tests/wpt/dom/parts/basic-dom-part-objects.tentative.html
:566: Uncaught TypeError: Cannot read properties of undefined (reading 'cloneNode')
[
  {
    "pass": false,
    "crash": false,
    "name": "tests/wpt/dom/parts/basic-dom-part-objects.tentative.html",
    "cases": [
      {
        "pass": false,
        "name": "tests/wpt/dom/parts/basic-dom-part-objects.tentative.html",
        "message": "JSExec"
      }
    ]
  }
]

In main:

$ zig build wpt -- --json tests/wpt/dom/parts/basic-dom-part-objects.tentative.html
[
  {
    "pass": false,
    "crash": false,
    "name": "tests/wpt/dom/parts/basic-dom-part-objects.tentative.html",
    "cases": [
      {
        "pass": false,
        "name": "tests/wpt/dom/parts/basic-dom-part-objects.tentative.html",
        "message": "TypeError: Cannot read properties of undefined (reading 'cloneNode')\n    at <anonymous>:15:42\n    at Array.forEach (<anonymous>)\n    at <anonymous>:7:14"
      }
    ]
  }
]

@krichprollsch
Copy link
Member

Fixed

$ zig build wpt -- --safe --json tests/wpt/dom/parts/basic-dom-part-objects.tentative.html
[
  {
    "pass": false,
    "crash": false,
    "name": "tests/wpt/dom/parts/basic-dom-part-objects.tentative.html",
    "cases": [
      {
        "pass": false,
        "name": "tests/wpt/dom/parts/basic-dom-part-objects.tentative.html",
        "message": "TypeError: Cannot read properties of undefined (reading 'cloneNode')\n    at <anonymous>:15:42\n    at Array.forEach (<anonymous>)\n    at <anonymous>:7:14"
      }
    ]
  }
]

@krichprollsch krichprollsch merged commit 5f5e01a into main Jul 18, 2024
@krichprollsch krichprollsch deleted the refacto_exec branch July 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants