Skip to content

Conversation

@karlseguin
Copy link
Collaborator

Allows easily building the project, following the steps in readme, without a github account or having some special git configuration.

If this change is acceptable, I can submit a similar PR for https://github.com/lightpanda-io/zig-js-runtime/blob/main/.gitmodules

Allows easily building the project, following the steps in readme, without
a github account or having some special git configuration.
@krichprollsch
Copy link
Member

Thanks @karlseguin 🙏
We used ssh for submodules when the repos were private. It doesn't makes sense now, you are right.
The similar PR for zig-jsruntime is welcome 👍

@krichprollsch krichprollsch merged commit a4e3f03 into lightpanda-io:main Jan 30, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
@karlseguin karlseguin deleted the submodules_over_https branch February 6, 2025 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants