Minor Reader tweaks #411
Merged
Minor Reader tweaks #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1- Remove `parser.trim`, it was only being used in 1 place. All other places are using `std.mem.trim(u8, X, &std.ascii.whitespace)`, so i updated MIME to use this as well 2- Use slightly more meaningful field name, i => pos, s = data 3- Leverage std.mem.indexOfScalarPos which can be more efficient for longer inputs (since it leverages SIMD)
krichprollsch
approved these changes
Feb 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1- Remove
parser.trim, it was only being used in 1 place. All other placesare using
std.mem.trim(u8, X, &std.ascii.whitespace), so i updated MIME touse this as well
2- Use slightly more meaningful field name, i => pos, s = data
3- Leverage std.mem.indexOfScalarPos which can be more efficient for longer
inputs (since it leverages SIMD)