Fix server hang on client disconnect #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightpanda-io#425 Add a few integration tests for the TCP server which are fast enough to be run as part of the unit tests (one of the new tests covers the above issue).
krichprollsch
approved these changes
Feb 19, 2025
|
@karlseguin this PR breaks I'm adding the tests on the ci test suite. server: mask (0.01ms)
error(server): Client Processing Error: error.NotFound
server: 404 (11.13ms)
thread 1220960 panic: attempt to use null value
================================================================================
"server: get /json/version" - WouldBlock
================================================================================
???:?:?Unwind error at address `: 0x1ed2081 in ??? ():0x
1ec16ff` (error.InvalidDebugInfo), trace may be incomplete
Panicked during a panic. Aborting.
???:?:?: 0x1eb6cb0 in ??? ()
unittest
└─ run test failure
error: the following command terminated unexpectedly:
/home/pierre/wrk/browser/.zig-cache/o/dbbef7fdd1df483910a085b9de2303f9/test
Build Summary: 2/4 steps succeeded; 1 failed
unittest transitive failure
└─ run test failure
└─ zig test Debug native cached 28ms MaxRSS:37M
├─ options cached
└─ options (reused)
error: the following build command failed with exit code 1:
/home/pierre/wrk/browser/.zig-cache/o/7a9935469ab9b5af96ef2ed0fef6c52a/build /usr/local/zig-0.13.0/zig /home/pierre/wrk/browser /home/pierre/wrk/browser/.zig-cache /home/pierre/.cache/zig --seed 0xa09a1bbb -Z9b5359a0c97c1386 unittest -freference-trace --summary all
make: *** [Makefile:97: unittest] Error 1 |
|
Here is the PR: #436 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#425
Add a few integration tests for the TCP server which are fast enough to be run as part of the unit tests (one of the new tests covers the above issue).