-
Notifications
You must be signed in to change notification settings - Fork 286
Add Usage Telemetry #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Usage Telemetry #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ef94f1 to
8ad102f
Compare
Collaborator
Author
|
Another good reason to replace |
e8340a7 to
cc13044
Compare
Member
|
@karlseguin after discussion, here is what we could add for the {
"iid": "ffffffff-ffff-ffff-ffff-ffffffffffff",
"version": "7b0e725",
"arch": "x86_64",
"os": "linux",
"mode": "serve",
"driver": "cdp",
"event": "navigate"
"tls": true,
"proxy": false, // is a proxy configured for the request, always false for now.
} |
Add batching, add install optional id (persisted) and execution id (per run)
This reverts commit 88850bc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends basic usage telemetry. Final URL will need to be changed (probably).
Added Telemetry section to readme (please review). And I the Privacy Policy (linked from the readme) might need updating to reflect this collection?
Currently, most things need an
AllocatorandLoopto run. Now we also need aTelemetry, and it isn't hard to imagine a not-so-distant future where various parts also need access to aConfig. Rather than adding more and more parameters, I've introduced anAppwhich is meant to group global data into a single variable, so that future additions are less likely to require touching so much code. Besides this change, the Telemetry code is relatively standalone.