browser: fix module URL resolution #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
resove-module
branch
from
1cfbf60 to
3fd8347
Compare
karlseguin
reviewed
Mar 15, 2025
src/browser/browser.zig
Outdated
| // if no src is present, we evaluate the text source. | ||
| // https://html.spec.whatwg.org/multipage/scripting.html#script-processing-model | ||
| fn evalScript(self: *Page, s: Script) !void { | ||
| self.current_script = &s; |
Collaborator
There was a problem hiding this comment.
Something weird about taking the address of this value and storing it as a field. But it does work, especially since you null it before you exit.
Would be nice if the module loader took arbitrary state per-load, but that's a bigger change, and would likely require allocating something on the heap to pass it through.
I do think evalScript should take a *const Script though. It won't change much - you'll still be storing a stack address in the field - but there's no reason for it to take a copy.
karlseguin
approved these changes
Mar 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #464