Add missing TokenList APIs #544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add value setter, keys(), values(), entries() and forEach(). Like nodelist, forEach still doesn't support `this` arg (gotta think about how to do this). I think these iterable methods are missing in a few places, so I added a generic Entries iterator and a generic Iterable. jsruntime will now map a Zig tuple to a JS array.
JsObject can now be used as a normal parameter. It'll receive the opaque value. This is largely useful when a Zig function takes an argument which it needs to pass back into a callback. JsThis is now a thin wrapper around JsObject for functions that was the JsObject of the receiver. This is for advanced usage where the Zig function wants to manipulate the v8.Object that represents the zig value. postAttach is an example of such usage.
krichprollsch
approved these changes
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add value setter, keys(), values(), entries() and forEach().
Like nodelist, forEach still doesn't supportthisarg (gotta think about how to do this).I think these iterable methods are missing in a few places, so I added a generic Entries iterator and a generic Iterable.
jsruntime will now map a Zig tuple to a JS array.