Don't [try] to run non-tests #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we treat every .html file in tests/wpt as-if it's a test. That isn't always the case. wpt has a manifest tool to generate a manifest (in JSON) of the tests, we should probably use that (but it's quite large). This PR filters out two groups. First, everything in resources/ appears to be things to _run_ the tests, not actual tests. Second, any file without a "testharness.js" doesn't appear to be a test either. Note that WPT's own manifest generator looks at this: https://github.com/web-platform-tests/wpt/blob/43a06153617aa58f877f9e5873c0a02290b1c2a8/tools/manifest/sourcefile.py#L676 (which is used later in the file to determine the type of file).
krichprollsch
approved these changes
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we treat every .html file in tests/wpt as-if it's a test. That isn't always the case. wpt has a manifest tool to generate a manifest (in JSON) of the tests, we should probably use that (but it's quite large).
This PR filters out two groups. First, everything in resources/ appears to be things to run the tests, not actual tests.
Second, any file without a "testharness.js" doesn't appear to be a test either. Note that WPT's own manifest generator looks at this: https://github.com/web-platform-tests/wpt/blob/43a06153617aa58f877f9e5873c0a02290b1c2a8/tools/manifest/sourcefile.py#L676 (which is used later in the file to determine the type of file).