Implement custom isEqualNode #558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netsurf's dom_node_is_equal appears to be both unsafe and incorrect. It's unsafe because various node types don't have the dom_node_get_attributes implementation so they default to setting the node attributes to null: https://github.com/lightpanda-io/libdom/blob/master/src/core/node.c#L658 However, it doesn't do a NULL check when comparing them, so it crashes: https://github.com/lightpanda-io/libdom/blob/da8b967905a38455e4f6b75cc9ad2767bae3ccde/src/core/namednodemap.c#L312 Furthermore, specific nodes need to be compared using specific attributes/values. This PR fixes a WPT crash.
krichprollsch
approved these changes
Apr 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netsurf's dom_node_is_equal appears to be both unsafe and incorrect. It's unsafe because various node types don't have the dom_node_get_attributes implementation so they default to setting the node attributes to null: https://github.com/lightpanda-io/libdom/blob/master/src/core/node.c#L658
However, it doesn't do a NULL check when comparing them, so it crashes: https://github.com/lightpanda-io/libdom/blob/da8b967905a38455e4f6b75cc9ad2767bae3ccde/src/core/namednodemap.c#L312
Furthermore, specific nodes need to be compared using specific attributes/values.
This PR fixes a WPT crash.