Skip to content

cdp: dispatch Page.frameNavigated before DOM.documentUpdated #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

cdp: dispatch Page.frameNavigated before DOM.documentUpdated #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/cdp/domains/page.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ pub fn pageNavigated(bc: anytype, event: *const Notification.PageNavigated) !voi
const target_id = bc.target_id orelse unreachable;
const session_id = bc.session_id orelse unreachable;

try cdp.sendEvent("DOM.documentUpdated", null, .{ .session_id = session_id });

// frameNavigated event
try cdp.sendEvent("Page.frameNavigated", .{
.type = "Navigation",
Expand All @@ -257,6 +255,11 @@ pub fn pageNavigated(bc: anytype, event: *const Notification.PageNavigated) !voi
},
}, .{ .session_id = session_id });

// The DOM.documentUpdated event must be send after the frameNavigated one.
// chromedp client expects to receive the events is this order.
// see https://github.com/chromedp/chromedp/issues/1558
try cdp.sendEvent("DOM.documentUpdated", null, .{ .session_id = session_id });

// domContentEventFired event
// TODO: partially hard coded
try cdp.sendEvent(
Expand Down
Loading