Remove global scope #580
Merged
Remove global scope #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjorsdonkers
commented
Apr 29, 2025
sjorsdonkers
commented
- Fixes some locals that were leaking onto the global scope
sjorsdonkers
commented
Apr 29, 2025
karlseguin
reviewed
Apr 29, 2025
| inline for (Types, 0..) |s, i| { | ||
| templates[i] = generateClass(@field(types, s.name), isolate); | ||
| @setEvalBranchQuota(10_000); | ||
| templates[i] = v8.Persistent(v8.FunctionTemplate).init(isolate, generateClass(@field(types, s.name), isolate)).castToFunctionTemplate(); |
Collaborator
There was a problem hiding this comment.
Are you not freeing these in deinit because you figure the isolate is going away anyways?
| // call on the isolate to encourage v8 to free any contexts which | ||
| // have been freed. | ||
| if (self.env.gc_hints) { | ||
| var handle_scope: v8.HandleScope = undefined; |
Collaborator
There was a problem hiding this comment.
We have to create a HandleScope to free memory?
Contributor
Author
There was a problem hiding this comment.
Apparently it crashes otherwise with the HandleScope message. Anything that creates a local requires a scope to be active. Before this was leaking the object into the global scope.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.