Rework WPT runner #589
Merged
Rework WPT runner #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have no crashing tests, remove safe mode. Allows better re-use of arenas, and if we do introduce a crash, it won't be easy to ignore. Could allow for re-using the environment across tests to further improve performance. Remove console now that we have a working console api.
Remove --safe option from WPT workflows (it's no longer valid) Include a total test/case summary when --summary or --text (default) is used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have no crashing tests, remove safe mode. Allows better re-use of arenas, and if we do introduce a crash, it won't be easy to ignore. Could allow for re-using the environment across tests to further improve performance.
Remove console now that we have a working console api.