Optimize intervals, and make sure they're probably cleaned up. #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A loop interval will no longer stop the loop from returning from `run`, and no longer requires mutating event_nb on each iteration. Re-enable microtask loop, which I accidentally stopped in a previous commit.
karlseguin
commented
May 7, 2025
| events_nb: usize, | ||
|
|
||
| // Used to stop repeating timeouts when loop.run is called. | ||
| stopping: bool, |
Collaborator
Author
There was a problem hiding this comment.
@krichprollsch do operations on events_nb really need to be synchronized/atomic? Isn't this all single threaded?
If I'm wrong, I should add atomic operations around stopping too.
Member
There was a problem hiding this comment.
Well I guess it was in case of future multi-threads use...
I'm not sure we should maintain it since many other things would break in this case...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A loop interval will no longer stop the loop from returning from
run, and no longer requires mutating event_nb on each iteration.Re-enable microtask loop, which I accidentally stopped in a previous commit.