implement TextEncoder #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krichprollsch
force-pushed
the
text-encoder
branch
from
25788f8 to
0c1c497
Compare
karlseguin
reviewed
May 12, 2025
| return error.InvalidUtf8Input; | ||
| } | ||
|
|
||
| // raw copy b/c we know the input is utf-8 |
Collaborator
There was a problem hiding this comment.
I don't think you'll need to allocate, and can use v directly:
pub fn _encode(_: *const TextEncoder, v: []const u8) !Env.TypedArray(u8) {
....
return .{.values = v}
}If you did need to allocate, you could use the call_arena, which is shorter-lived, since the data gets copied into v8 anyways.
| try runner.testCases(&.{ | ||
| .{ "var encoder = new TextEncoder();", "undefined" }, | ||
| .{ "encoder.encoding;", "utf-8" }, | ||
| .{ "encoder.encode('€');", "Uint8Array(3) [226, 130, 172]" }, |
Collaborator
There was a problem hiding this comment.
Worth testing the error case.
krichprollsch
force-pushed
the
text-encoder
branch
2 times, most recently
from
71f8583 to
e792257
Compare
karlseguin
approved these changes
May 13, 2025
| @@ -0,0 +1,65 @@ | |||
| // Copyright (C) 2023-2024 Lightpanda (Selecy SAS) | |||
Member
Author
There was a problem hiding this comment.
good question. for now all the headers are to 2024. idk if we should update ti. I will talk that with @francisbouvier
| const std = @import("std"); | ||
|
|
||
| const Env = @import("../env.zig").Env; | ||
| const SessionState = @import("../env.zig").SessionState; |
krichprollsch
force-pushed
the
text-encoder
branch
from
e792257 to
9922951
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #627