Skip to content

window.requestAnimationFrame #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

window.requestAnimationFrame #637

merged 2 commits into from
May 13, 2025

Conversation

@sjorsdonkers
Copy link
Contributor

@sjorsdonkers sjorsdonkers commented May 13, 2025

Depends on: #636

Not sure how I feel about immediately executing the callback.
Used in Playwright click

@sjorsdonkers sjorsdonkers changed the base branch from main to performance_now May 13, 2025 14:18
@karlseguin
Copy link
Collaborator

karlseguin commented May 13, 2025 •
edited
Loading

LGTM, but you might as well implement the corresponding cancelAnimationFrame which would no-op. I checked, it doesn't care if the request_id is invalid or anything.

Base automatically changed from performance_now to main May 13, 2025 15:42
@sjorsdonkers sjorsdonkers force-pushed the requestAnimationFrame branch from 841867b to bbeec0e Compare May 13, 2025 16:18
@sjorsdonkers sjorsdonkers merged commit b2605dd into main May 13, 2025
9 checks passed
@sjorsdonkers sjorsdonkers deleted the requestAnimationFrame branch May 13, 2025 16:24
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjorsdonkers @karlseguin