Move Session, Page and Renderer into their own respective files #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
approved these changes
May 15, 2025
Contributor
sjorsdonkers
left a comment
sjorsdonkers
left a comment
There was a problem hiding this comment.
Yea, I agree we should do this.
Haven't checked if we have any unused imports, but it looks good.
krichprollsch
approved these changes
May 15, 2025
karlseguin
force-pushed
the
split_browser_file
branch
from
c592709 to
e44e68f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fine with keeping things as-is, but it is getting a little messy in there, and we're only going to add more and more logic. I think this is cleaner, and the sooner we do it, the easier.
The main downside is that some functions, like session.init need to be made
pub, whereas before, they weren't.