Introduce a "transfer_arena" #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some data has to exist specifically for the navigation of one page to another. For example, if a hyperlink is clicked, the URL begins its life with the original page, but is transferred to the new page. The page_arena cannot be used for such data. It's possible to use the session_arena, but it's lifetime is much longer and, given enough navigation, could accumulate a lot of memory. The new transfer_arena exists within the session, but only exists until the next navigation. While currently only used for the navigation URL, the main goal here is to have a place to put the request body on form submission, which has a lifetime similar to a click url. While I'm at it, I promoted the existing session arena and the new transfer arena to the browser, allowing better memory re-use between sessions.
src/browser/session.zig
Outdated
| var buf: [2048]u8 = undefined; | ||
| var fba = std.heap.FixedBufferAllocator.init(&buf); | ||
| const url = try self.page.?.url.resolve(fba.allocator(), url_string); | ||
| _ = self.browser.transfer_arena.reset(.{ .retain_with_limit = 1 * 1024 * 1024 }); |
Member
There was a problem hiding this comment.
It surprises me the transfer_arena is reset at the beginning of the page navigate.
What about instead reset the transfer_arena after the end of pageNavigate? The data must live longer?
If we reset it at the beginning of the pageNavigate it must be explicit we shouldn't use it outside the function...
Collaborator
Author
There was a problem hiding this comment.
I wasn't thinking. I originally had the reset inside page.navigate, but I was happier with the page knowing nothing about it. Don't know why I didn't think of just defer inside the function.
krichprollsch
approved these changes
May 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some data has to exist specifically for the navigation of one page to another. For example, if a hyperlink is clicked, the URL begins its life with the original page, but is transferred to the new page. The page_arena cannot be used for such data.
It's possible to use the session_arena, but it's lifetime is much longer and, given enough navigation, could accumulate a lot of memory.
The new transfer_arena exists within the session, but only exists until the next navigation.
While currently only used for the navigation URL, the main goal here is to have a place to put the request body on form submission, which has a lifetime similar to a click url.
While I'm at it, I promoted the existing session arena and the new transfer arena to the browser, allowing better memory re-use between sessions.