Allow webapis to register a destructor to do cleanup on scope (page) end #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add destructor to XHR to abort any inflight requests.
Keep request around, as the http/client needs it for cleanup. Calling abort on an already deinit'd request is safe.
This PR will be only for having the destructor hook. XHR/http.client changes to leverage this will be done in a subsequent PR.
Collaborator
Author
|
I re-worked this PR to focus only on the destructor callback hook. Nothing is currently using it. A separate commit will add the destructor to XHR...it requires more changes than I was expecting. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add destructor to XHR to abort any inflight requests.