dom.querySelector #673
Merged
dom.querySelector #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
commented
May 20, 2025
karlseguin
reviewed
May 21, 2025
|
|
||
| // Dispatch setChildNodesEvents to inform the client of the subpart of node tree covering the results. | ||
| var array = [1]*parser.Node{selected_node}; | ||
| try dispatchSetChildNodes(cmd, array[0..]); |
Collaborator
There was a problem hiding this comment.
Suggested change
| try dispatchSetChildNodes(cmd, array[0..]); | |
| try dispatchSetChildNodes(cmd, &.{selected_node}); |
This this will work.
Contributor
Author
There was a problem hiding this comment.
I have not been able to find the right incantation..
try dispatchSetChildNodes(cmd, &.{selected_node});
results in:
error: expected type '[]*cimport.struct_dom_node_internal', found '*const [1]*cimport.struct_dom_node_internal'
try dispatchSetChildNodes(cmd, &.{selected_node});
^~~~~~~~~~~~~~~~~
src/cdp/domains/dom.zig:216:36: note: cast discards const qualifier
src/cdp/domains/dom.zig:103:47: note: parameter type declared here
fn dispatchSetChildNodes(cmd: anytype, nodes: []*parser.Node) !void {
sjorsdonkers
force-pushed
the
dom.querySelector
branch
from
928e7df to
e0caf02
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dom.querySelectordom.querySelectorAllFor use in chromedp/click