Move jsValueToZig from Caller to the Scope #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caller is a transient object that exists only for calling Zig functions from JS. But jsValueToZig is more generally useful and can be used outside of an explicit JS call. The scope is a better place for these as it's generally referenced already by any code that would need to map values (i.e. a Callback).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caller is a transient object that exists only for calling Zig functions from JS. But jsValueToZig is more generally useful and can be used outside of an explicit JS call. The scope is a better place for these as it's generally referenced already by any code that would need to map values (i.e. a Callback).