Skip long setTimeout/setInterval #716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
force-pushed
the
skip_long_timeouts
branch
from
ef1b00e to
54a818a
Compare
I guess this should eventually become a configuration option - what time is too long and should they be skipped or just be run sooner? But for now, this unblocks from fetching a site like DDG which does a setTimeout of 2 minutes.
karlseguin
force-pushed
the
skip_long_timeouts
branch
from
54a818a to
608e0a0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this should eventually become a configuration option - what time is too long and should they be skipped or just be run sooner?
But for now, this unblocks from fetching a site like DDG which does a setTimeout of 2 minutes.