Fix anchor href #740
Merged
Fix anchor href #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
approved these changes
Jun 2, 2025
| pub fn get_hostname(self: *parser.Anchor, page: *Page) ![]const u8 { | ||
| var u = try url(self, page); | ||
| return try page.arena.dupe(u8, u.get_hostname()); | ||
| return u.get_hostname(); |
Contributor
There was a problem hiding this comment.
I think we could construct the url here with .if_needed, no?
Collaborator
Author
There was a problem hiding this comment.
The whole URL constructing per getter is a bit much. I guess it isn't called too often, plus it's maybe just as likely to get mutated.
Everything touching URLs needs a rewrite at some point. It's a bit of a mess, starting with std.Uri.
karlseguin
force-pushed
the
fix_anchor_href
branch
from
12e3fdc to
4c8e2a1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.