Skip to content

Guard against null object when trying to fetch a function #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Guard against null object when trying to fetch a function #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/browser/dom/event_target.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,4 +222,10 @@ test "Browser.DOM.EventTarget" {
.{ "content.dispatchEvent(new Event('he'));", null },
.{ "obj1.calls", "1" },
}, .{});

// doesn't crash on null receiver
try runner.testCases(&.{
.{ "content.addEventListener('he2', null);", null },
.{ "content.dispatchEvent(new Event('he2'));", null },
}, .{});
}
8 changes: 8 additions & 0 deletions src/runtime/js.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1400,7 +1400,11 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
}

pub fn getFunction(self: JsObject, name: []const u8) !?Function {
if (self.isNullOrUndefined()) {
return null;
}
const scope = self.scope;

const js_name = v8.String.initUtf8(scope.isolate, name);

const js_value = try self.js_obj.getValue(scope.context, js_name.toName());
Expand All @@ -1409,6 +1413,10 @@ pub fn Env(comptime State: type, comptime WebApis: type) type {
}
return try scope.createFunction(js_value);
}

pub fn isNullOrUndefined(self: JsObject) bool {
return self.js_obj.toValue().isNullOrUndefined();
}
};

// This only exists so that we know whether a function wants the opaque
Expand Down