Delay requestAnimation #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is often called in a tight loop (the callback to requestAnimation typically calls requestAnimation). Instead, we can treat it like a setTimeout with a short delay (5ms ?). This has the added benefit of making it cancelable, FWIW.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is often called in a tight loop (the callback to requestAnimation typically calls requestAnimation).
As-is, it can result in the browser locking due to the
requestAnimationcallback callingrequestAnimation. (I can reproduce this blocking in some cases. I'm not sure why it doesn't always block if it calls itself.).Instead, we can treat it like a setTimeout with a short delay (5ms ?). This has the added benefit of making it cancelable, FWIW.