Minimal CSSStyleSheet #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlseguin
reviewed
Jun 18, 2025
src/browser/cssom/css_stylesheet.zig
Outdated
| pub const CSSStyleSheet = struct { | ||
| pub const prototype = *StyleSheet; | ||
|
|
||
| css_rules: *CSSRuleList, |
Collaborator
There was a problem hiding this comment.
Why is this a pointer?
Contributor
Author
There was a problem hiding this comment.
No longer a pointer
| return .{ .css_rules = rules, .owner_rule = null }; | ||
| } | ||
|
|
||
| pub fn get_ownerRule(_: *CSSStyleSheet) ?*CSSImportRule { |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub fn get_ownerRule(_: *CSSStyleSheet) ?*CSSImportRule { | |
| pub fn get_ownerRule(_: *CSSStyleSheet) ?*CSSImportRule { |
Not a big deal. Can also be done in get_cssRules
src/browser/cssom/stylesheet.zig
Outdated
| title: []const u8, | ||
| type: []const u8, | ||
|
|
||
| pub fn get_disabled(self: *StyleSheet) bool { |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub fn get_disabled(self: *StyleSheet) bool { | |
| pub fn get_disabled(self: *const StyleSheet) bool { |
(same as for the other ones)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super barebones CSSStyleSheet, mostly for just resolving various Custom Elements complaining about a lack of the CSSStyleSheet interface.
A lot of functionality is not implemented but it seems to allow more components to load on the Reddit example.