Skip to content

Conversation

@karlseguin
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sjorsdonkers sjorsdonkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krichprollsch
Copy link
Member

I don't think it changes anything but maybe we should use EnqueueMicrotask ?

@karlseguin
Copy link
Collaborator Author

I'd like to keep it as is. It makes setTimeout, setInterval, requestAnimationFrame, requestIdleCallback (TBD) and queueMicrotask all have the same implementation. It's also 1 less layer of indirection and keeps control of it in our code, rather than passing it to v8.

Practically, there isn't much difference, since the v8 microtask is itself run from a IO loop timeout and both will run on the next run call.

@karlseguin karlseguin merged commit d08fd29 into main Jul 13, 2025
10 checks passed
@karlseguin karlseguin deleted the window_queueMicrotask branch July 13, 2025 01:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants