Noop CDP methods that go-rod requires #887
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-rod appears to stop processing when it receives an error, such as UnknownMethod. Added placeholder handlers for Network.setUserAgentOverride and Page.stopLoading. Setting a custom user agent is something still being discussed, so no-oping it seems reasonable. And, due to the currently synchronous nature of the initial page load, no-oping stopLoading also seems reasonable. #867
sjorsdonkers
approved these changes
Jul 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-rod appears to stop processing when it receives an error, such as UnknownMethod. Added placeholder handlers for Network.setUserAgentOverride and Page.stopLoading.
Setting a custom user agent is something still being discussed, so no-oping it seems reasonable. And, due to the currently synchronous nature of the initial page load, no-oping stopLoading also seems reasonable.
#867