Trigger the DOMContentLoaded on the Window #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is hacky, but it's inspired by how NetSurf does it. While the Window isn't the parent of the Document, many events should bubble from the Document to the Window. libdom simply doesn't handle this (it has no concept of a Window, and the Document has no parent). We potentially need to do this for multiple event types (NetSurf only does it for the 'load' event as far as I can tell). It would be nice to find a generic way to do this...maybe intercept any addEventListener on the body and registering special events on the Window? For now, `DOMContentLoaded` is the blocking (for finance.yahoo.com) and we can see if this is really an issue for other event types.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hacky, but it's inspired by how NetSurf does it. While the Window isn't the parent of the Document, many events should bubble from the Document to the Window. libdom simply doesn't handle this (it has no concept of a Window, and the Document has no parent).
We potentially need to do this for multiple event types (NetSurf only does it for the 'load' event as far as I can tell). It would be nice to find a generic way to do this...maybe intercept any addEventListener on the body and registering special events on the Window? For now,
DOMContentLoadedis the blocking (for finance.yahoo.com) and we can see if this is really an issue for other event types.