Skip to content

fix memory leak #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

fix memory leak #944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fa542b
fix memory leak
karlseguin Aug 14, 2025
f9352e2
same memory leak, different place
karlseguin Aug 14, 2025
31f3c27
fix build error...sorry
karlseguin Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/browser/ScriptManager.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ pub fn addFromElement(self: *ScriptManager, element: *parser.Element) !void {
errdefer pending_script.deinit();

var headers = try HttpClient.Headers.init();
try page.requestCookie(.{}).headersForRequest(self.allocator, remote_url.?, &headers);
try page.requestCookie(.{}).headersForRequest(page.arena, remote_url.?, &headers);

try self.client.request(.{
.url = remote_url.?,
Expand Down Expand Up @@ -297,7 +297,7 @@ pub fn blockingGet(self: *ScriptManager, url: [:0]const u8) !BlockingResult {
};

var headers = try HttpClient.Headers.init();
try self.page.requestCookie(.{}).headersForRequest(self.allocator, url, &headers);
try self.page.requestCookie(.{}).headersForRequest(self.page.arena, url, &headers);

var client = self.client;
try client.blockingRequest(.{
Expand Down