Removes the log for unknown script tags #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some sites have a lot of text/template or application/json, and it just adds noise to the logs.
| } | ||
| if (std.ascii.eqlIgnoreCase(script_type, "application/ld+json")) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure I understand why you remove these kind?
The won't create more log warning then?
Member
There was a problem hiding this comment.
oh you remove the warning too 🤦 my bad.
What about using debug instead?
Collaborator
Author
There was a problem hiding this comment.
Thought about it. On the fence.
On the one hand I thought: good to log in case there's a type we don't handle that we should (which is the intention behind the original code). On the other hand, some sites have a lot of text/template, and I felt the noise outweighed the maybe-one-day-it-will-be-useful
krichprollsch
approved these changes
Aug 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sites have a lot of text/template or application/json, and it just adds noise to the logs.