Skip to content

Fix two endlessly recursive calls in node. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Fix two endlessly recursive calls in node. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/core/element.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,6 +1467,11 @@ dom_exception _dom_element_lookup_namespace(dom_node_internal *node,
return dom_element_get_attribute(node, xmlns, result);
}

if (node->parent == NULL) {
*result = NULL;
return DOM_NO_ERR;
}

return dom_node_lookup_namespace(node->parent, prefix, result);
}

Expand Down
4 changes: 2 additions & 2 deletions src/core/node.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,7 +1557,7 @@ dom_exception _dom_node_lookup_prefix(dom_node_internal *node,
dom_string *namespace, dom_string **result)
{
if (node->parent != NULL)
return dom_node_lookup_prefix(node, namespace, result);
return dom_node_lookup_prefix(node->parent, namespace, result);
else
*result = NULL;

Expand All @@ -1576,7 +1576,7 @@ dom_exception _dom_node_is_default_namespace(dom_node_internal *node,
dom_string *namespace, bool *result)
{
if (node->parent != NULL)
return dom_node_is_default_namespace(node, namespace, result);
return dom_node_is_default_namespace(node->parent, namespace, result);
else
*result = false;
return DOM_NO_ERR;
Expand Down
Loading