Array like #154
Merged
Array like #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Rationale: this feature has nothing to do with the Type init. The idea is to get/set values on the JS object itself after its instantiation. Thoses actions are by definition dynamic and do not affect the underling Type. By consequence the corresponding Zig object will not have those values. Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Member
Author
|
I'm not happy with the name See my commit msg on f322ae8 |
Member
Author
|
At the end I was able to make this PR without depending on the Zig <> JS object map relation. But of course once we have that we will have to update to call |
Member
What about calling it |
francisbouvier
force-pushed
the
array_like
branch
from
798d128 to
be960ad
Compare
Signed-off-by: Francis Bouvier <francis@lightpanda.io>
Split assertFuncHasParam to assertFuncHasParamT and assertFuncParamIsT Better logic of strict parameter on assertFuncIsMethod Signed-off-by: Francis Bouvier <francis@lightpanda.io>
krichprollsch
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #126
Relates to #49