Skip to content

loop: add a context id for callback events #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

loop: add a context id for callback events #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/loop.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ pub const SingleThreaded = struct {
events_nb: *usize,
cbk_error: bool = false,

// ctx_id is incremented each time the loop is reset.
// All context are
ctx_id: u32 = 0,

const Self = @This();
pub const Completion = IO.Completion;

Expand Down Expand Up @@ -116,6 +120,7 @@ pub const SingleThreaded = struct {
const ContextTimeout = struct {
loop: *Self,
js_cbk: ?JSCallback,
ctx_id: u32,
};

fn timeoutCallback(
Expand All @@ -125,6 +130,11 @@ pub const SingleThreaded = struct {
) void {
defer ctx.loop.freeCbk(completion, ctx);

// If the loop's context id has changed, don't call the js callback
// function. The callback's memory has already be cleaned and the
// events nb reset.
if (ctx.ctx_id != ctx.loop.ctx_id) return;

const old_events_nb = ctx.loop.removeEvent();
if (builtin.is_test) {
report("timeout done, remaining events: {d}", .{old_events_nb - 1});
Expand Down Expand Up @@ -155,6 +165,7 @@ pub const SingleThreaded = struct {
ctx.* = ContextTimeout{
.loop = self,
.js_cbk = js_cbk,
.ctx_id = self.ctx_id,
};
const old_events_nb = self.addEvent();
self.io.timeout(*ContextTimeout, ctx, timeoutCallback, completion, nanoseconds);
Expand All @@ -168,6 +179,7 @@ pub const SingleThreaded = struct {
const ContextCancel = struct {
loop: *Self,
js_cbk: ?JSCallback,
ctx_id: u32,
};

fn cancelCallback(
Expand All @@ -177,6 +189,11 @@ pub const SingleThreaded = struct {
) void {
defer ctx.loop.freeCbk(completion, ctx);

// If the loop's context id has changed, don't call the js callback
// function. The callback's memory has already be cleaned and the
// events nb reset.
if (ctx.ctx_id != ctx.loop.ctx_id) return;

const old_events_nb = ctx.loop.removeEvent();
if (builtin.is_test) {
report("cancel done, remaining events: {d}", .{old_events_nb - 1});
Expand Down Expand Up @@ -209,6 +226,7 @@ pub const SingleThreaded = struct {
ctx.* = ContextCancel{
.loop = self,
.js_cbk = js_cbk,
.ctx_id = self.ctx_id,
};

const old_events_nb = self.addEvent();
Expand All @@ -219,7 +237,13 @@ pub const SingleThreaded = struct {
}

pub fn cancelAll(self: *Self) void {
self.resetEvents();
self.io.cancel_all();
}

// Reset all existing callbacks.
pub fn reset(self: *Self) void {
self.ctx_id += 1;
self.resetEvents();
}

Expand Down