Add RemoteObject subtype #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Zig structures to define a `sub_type` which will be included in the RemoteObject's subtype field (and will generate an empty description field) External PersitedObjects now wrap our own ExternalEntry wrapper, which includes a pointer to the Zig instance (what we used to have before). This approach allows us to associate metadata with a v8.Value. We currently add the subtype if available.
Member
|
I'm testing this PR with |
src/engines/v8/v8.zig
Outdated
| // the proper subtype (and description) fields in the returned JSON. | ||
| // V8 will give us a Value and ask us for the subtype. Hence, we store it | ||
| // here. | ||
| sub_type: ?[:0]const u8, |
Member
There was a problem hiding this comment.
It seems we have a finite list of subtypes: https://chromedevtools.github.io/devtools-protocol/tot/Runtime/#type-RemoteObject
Maybe we could use an enum instead?
Collaborator
Author
There was a problem hiding this comment.
The list of subtypes is known, from Browser's point of view. But in zig-js-runtime, just like in V8 itself, it's an arbitrary application-specific value.
I did however change the type to ?[*c]const u8, which is what we actually need for the V8 interface and is 8 bytes smaller. With this change, the @sizeOf(ExternalEntry) is the same as-if we were using an enum (assuming padding). Also, this value is, always a string literal, so it's allocation-free.
Makes the @sizeof(ExternalEntry) 16, instead of 24 and works just as well with the string literal we expect it to be set to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Zig structures to define a
sub_typewhich will be included in the RemoteObject's subtype field (and will generate an empty description field)External PersitedObjects now wrap our own ExternalEntry wrapper, which includes a pointer to the Zig instance (what we used to have before). This approach allows us to associate metadata with a v8.Value. We currently add the subtype if available.