Expose InspectorClient valueSubtype and descriptionForValueSubtype #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the inspector returns a RemoteObject, the proper subType must be returned in order for the driver (i.e. puppeteer) to know what methods are available. For example, on any page.$eval, the first thing puppeteer does is request the document object via a Runtime.callFunctionOn which simply does return document; If the description of the document that we return (a "RemoteObject") doesn't include the "node" subtype, the puppeteer will fail. This PR provides the hooks for an implementation to provide its own valueSubtype implementation. However, in order for v8 to include the `node` field, we must always also include a "description" field, which is why this PR also allows implementations to provide its own `descriptionForValueSubtype`.
| const t = std.testing; | ||
|
|
||
| const c = @cImport({ | ||
| pub const c = @cImport({ |
Collaborator
Author
There was a problem hiding this comment.
When the implementation is written in zig-js-runtime (or maybe browser), they'll receive the raw C++ objects (c.Context and c.Value instead of v8.Context and v8.Value).
The only way I figured out how to provide a wrapper, is to do something like StdOptions, but that requires defining these things in main.zig (i.e. root), which, maybe it's just me, but I don't love.
Member
There was a problem hiding this comment.
I'm ok it's better to keep it ilke this.
krichprollsch
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the inspector returns a RemoteObject, the proper subType must be returned in order for the driver (i.e. puppeteer) to know what methods are available.
For example, on any page.$eval, the first thing puppeteer does is request the document object via a Runtime.callFunctionOn which simply does
return document;
If the description of the document that we return (a "RemoteObject") doesn't include the "node" subtype, the puppeteer will fail.
This PR provides the hooks for an implementation to provide its own valueSubtype implementation. However, in order for v8 to include the
nodefield, we must always also include a "description" field, which is why this PR also allows implementations to provide its owndescriptionForValueSubtype.