Skip to content

DEVOPS-2720-added-support-for-user-key-encryption #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

DEVOPS-2720-added-support-for-user-key-encryption #58

merged 1 commit into from
May 13, 2025

Conversation

@yitzhaktal
Copy link
Contributor

@yitzhaktal yitzhaktal commented May 7, 2025

No description provided.

@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch from 2d04570 to 3c1d569 Compare May 7, 2025 16:40
@yitzhaktal
Copy link
Contributor Author

yitzhaktal commented May 7, 2025 •
edited
Loading

Use cases:

  • Fresh installation: need to check that only one encryption key is mounted (and not all of them). V
  • Existing installation, without key, which is upgraded: need to check that new key is added to the existing backend secret. V
  • Existing installation, with a key, which is upgraded: the key is maintained. V
  • Existing installation, with a key that is rotated, which is upgraded: the key exist + a new key (0,1,2,3). V

@yitzhaktal yitzhaktal requested review from imeliran and moshiko-s May 7, 2025 17:32
@yitzhaktal yitzhaktal changed the title DEVOPS-2720 - Added support for user key encryption DEVOPS-2720-added-support-for-user-key-encryption May 8, 2025
imeliran
imeliran reviewed May 8, 2025
View reviewed changes
imeliran
imeliran reviewed May 8, 2025
View reviewed changes
imeliran
imeliran reviewed May 8, 2025
View reviewed changes
imeliran
imeliran reviewed May 8, 2025
View reviewed changes
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch 4 times, most recently from 1eca4b0 to 16d1c5a Compare May 11, 2025 08:55
@yitzhaktal yitzhaktal requested a review from imeliran May 11, 2025 08:57
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch 2 times, most recently from 9a629db to 0c650a3 Compare May 11, 2025 09:07
moshiko-s
moshiko-s reviewed May 11, 2025
View reviewed changes
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch 5 times, most recently from 9374eb4 to 7338009 Compare May 12, 2025 09:18
@yitzhaktal yitzhaktal requested a review from moshiko-s May 12, 2025 09:19
imeliran
imeliran reviewed May 12, 2025
View reviewed changes
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch from 7338009 to d7206e2 Compare May 12, 2025 14:06
@yitzhaktal yitzhaktal requested a review from imeliran May 12, 2025 14:06
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch from d7206e2 to 323b55b Compare May 13, 2025 09:09
imeliran
imeliran reviewed May 13, 2025
View reviewed changes
@yitzhaktal yitzhaktal force-pushed the DEVOPS-2720-added-user-encryption-key-support branch from 323b55b to 0fe759c Compare May 13, 2025 09:44
@yitzhaktal yitzhaktal requested a review from imeliran May 13, 2025 09:45
@yitzhaktal yitzhaktal merged commit a42004d into main May 13, 2025
1 check passed
@yitzhaktal yitzhaktal deleted the DEVOPS-2720-added-user-encryption-key-support branch May 13, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imeliran imeliran imeliran approved these changes

@moshiko-s moshiko-s Awaiting requested review from moshiko-s

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yitzhaktal @imeliran @moshiko-s