Skip to content

Conversation

@mhrheaume
Copy link
Contributor

Created a wrapper method for create_lnurl_invoice that does the SHA256 hash on the metadata parameter.

Fixes LIG-3254 .

@mhrheaume mhrheaume requested a review from jklein24 June 15, 2023 23:52
): InvoiceData {
requireValidAuth()

val md = MessageDigest.getInstance("SHA-256")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can throw this in a separate function under utils if you'd like as well @jklein24 .

Copy link
Contributor

@jklein24 jklein24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for also adding the unit test :-)

@mhrheaume mhrheaume merged commit 4dbd856 into develop Jun 16, 2023
@mhrheaume mhrheaume deleted the mhr/lnurl_lsclient_kotlin branch June 16, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants