-
Notifications
You must be signed in to change notification settings - Fork 56
Referenced documents support on /streaming_query #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @TamiTakamiya
IDK if @tisnik or @umago want to support customised meta-data longer-term but this certainly solves our immediate use case for Referenced Documents.
Does this also need adding to non-stream support?
aef46e6 to
9c4f5b7
Compare
umago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, suggestion inline
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks ok, thank you. Just please:
- rebase
- add the check mentioned by @umago to make sure the service won't fail with NPE
Then we can merge. Thank you in advance.
9c4f5b7 to
b2385be
Compare
umago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comment
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thank you
Description
Referenced documents support on /streaming_query
The code assumes that the vector DB contains
docs_urlandtitlein metadata. They are found in the vector DB built for road-core/service.Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing