Skip to content

LCORE-326: Add arm64 image building for releases #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

LCORE-326: Add arm64 image building for releases #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/build_and_push_release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ jobs:
- name: Install buildah
run: |
sudo apt update
sudo apt install -y buildah
# qemu is required for arm64 builds
sudo apt install -y buildah qemu-user-static
- name: Checkout code
uses: actions/checkout@v4
- name: Build image with Buildah
Expand All @@ -37,7 +38,17 @@ jobs:
${{ env.LATEST_TAG }}
containerfiles: |
${{ env.CONTAINER_FILE }}
archs: amd64, arm64
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Whitespace in archs input may break manifest creation

The action splits on commas; the extra space is preserved on some Node versions and causes an “unsupported architecture ‘ arm64’ ” error.

-          archs: amd64, arm64
+          archs: amd64,arm64
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
archs: amd64, arm64
archs: amd64,arm64
🤖 Prompt for AI Agents 
In .github/workflows/build_and_push_release.yaml at line 41, remove the space
after the comma in the archs input so it reads "amd64,arm64" without any spaces.
This prevents the action from interpreting the architecture string with leading
whitespace, which causes errors during manifest creation.

oci: true
- name: Check images
run: |
buildah images | grep '${{ env.IMAGE_NAME }}'
echo '${{ steps.build_image.outputs.image }}'
echo '${{ steps.build_image.outputs.tags }}'
- name: Check manifest
run: |
set -x
buildah manifest inspect ${{ steps.build_image.outputs.image }}:${{ env.LATEST_TAG }}
- name: Push image to Quay.io
uses: redhat-actions/push-to-registry@v2
with:
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ To pull and run the image with own configuration:

If a connection in your browser does not work please check that in the config file `host` option looks like: `host: 0.0.0.0`.

Container images are built for the following platforms:
1. `linux/amd64` - main platform for deployment
1. `linux/arm64`- Mac users with M1/M2/M3 CPUs

# Endpoints

The service provides health check endpoints that can be used for monitoring, load balancing, and orchestration systems like Kubernetes.
Expand Down