Skip to content

LCORE-303: fix integration tests #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

LCORE-303: fix integration tests #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/integration/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
from models.config import ModelContextProtocolServer


@pytest.fixture
def configuration_filename() -> str:
@pytest.fixture(name="configuration_filename")
def configuration_filename_fixture() -> str:
"""Retrieve configuration file name to be used by integration tests."""
return "tests/configuration/lightspeed-stack.yaml"

Expand All @@ -17,7 +17,7 @@ def test_default_configuration() -> None:
cfg = configuration
assert cfg is not None
with pytest.raises(Exception, match="logic error: configuration is not loaded"):
configuration.configuration
configuration.configuration # pylint: disable=pointless-statement


def test_loading_proper_configuration(configuration_filename: str) -> None:
Expand Down Expand Up @@ -60,7 +60,7 @@ def test_loading_proper_configuration(configuration_filename: str) -> None:

# check MCP servers section
mcp_servers = cfg.mcp_servers
assert mcp_servers != []
assert mcp_servers != [] # pylint: disable=use-implicit-booleaness-not-comparison
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Pylint disable flag likely misspelled – will fail CI

The message ID seems to be use-implicit-boolean-value (or similar) – not use-implicit-booleaness-not-comparison.
An unknown-message ID causes pylint to error with unknown-option, breaking the lint pipeline.

Additionally, the explicit != [] comparison that triggered the warning can be rewritten idiomatically:

-    assert mcp_servers != []  # pylint: disable=use-implicit-booleaness-not-comparison
+    assert mcp_servers  # non-empty list

If you still need to silence pylint, use the correct message ID:

assert mcp_servers  # pylint: disable=use-implicit-boolean-value
🤖 Prompt for AI Agents 
In tests/integration/test_configuration.py at line 63, the pylint disable flag
is misspelled as use-implicit-booleaness-not-comparison, which causes CI to
fail. Replace the assertion "assert mcp_servers != []  # pylint:
disable=use-implicit-booleaness-not-comparison" with the idiomatic "assert
mcp_servers  # pylint: disable=use-implicit-boolean-value" using the correct
pylint message ID to properly silence the warning.

assert len(mcp_servers) == 3
assert mcp_servers[0] == ModelContextProtocolServer(
name="server1", provider_id="provider1", url="http://url.com:1"
Expand Down