-
Notifications
You must be signed in to change notification settings - Fork 55
LCORE-379: fixed run.yaml to be compatible with Llama Stack 0.2.14 #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe telemetry provider configuration in the Changes
Estimated code review effort1 (~2 minutes) Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/run.yaml (1)
91-94: Consider parameterisingservice_namefor multi-deployment setups
If this file is reused across environments (dev / staging / prod) or multiple Lightspeed deployments, hard-coding the value can make it harder to differentiate traces. You could allow override via an env-var:service_name: ${env.SERVICE_NAME:-lightspeed-stack}This keeps the default while giving ops flexibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/run.yaml(1 hunks)
🔇 Additional comments (1)
examples/run.yaml (1)
92-92: Telemetry now has a validservice_name– looks correct
Setting a non-emptyservice_nameis required by Llama Stack ≥ 0.2.14 and by OpenTelemetry, so this change unblocks traces without side effects.
Description
LCORE-379: fixed
run.yamlto be compatible with Llama Stack 0.2.14Type of change
Related Tickets & Documents
Summary by CodeRabbit