-
Notifications
You must be signed in to change notification settings - Fork 54
Feat: Update base image to fix Konflux RPM signature scan #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Containerfile was updated to use a new base image, switching from a minimal UBI image to a Python 3.12-specific UBI image. As a result, explicit installation commands for Python 3.12, development headers, and pip were removed, since the new base image already includes them. No other changes were made. Changes
Estimated code review effort1 (~2 minutes) Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@matysek PTAL please |
This commit update the Containerfile, switching the base image to the ubi9/python-312-minimal image. This eliminates manual Python installations, resulting in a cleaner and more efficient build. This change resolves issues with the Konflux RPM signature scan by mitigating the risk of unverified artifact injection. Signed-off-by: Eran Cohen <eranco@redhat.com>
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks ok
Description
This commit update the Containerfile, switching the base image to the ubi9/python-312 image. This eliminates manual Python installations, resulting in a cleaner and more efficient build. This change resolves issues with the Konflux RPM signature scan by mitigating the risk of unverified artifact injection.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit